CT: Playwright to support authentication - Githubissues

phetsims / aqua

Automatic QUality Assurance

MIT License

2 stars 4 forks source link

CT: Playwright to support authentication #188

Closed zepumph closed 8 months ago

zepumph commented 1 year ago

Over in https://github.com/phetsims/phet-io/issues/1944 we got puppeteer working with phet-io basic authentication, but we need to solve this for playwright before that issue can be complete.

zepumph commented 1 year ago

today we decided in our "green team" meeting that type:automated-testing only applies to failing CT tests. Unlabelling.

zepumph commented 9 months ago

https://www.youtube.com/watch?v=2EtA5QtHOHg seems to be my best lead so far, I can just add it directly as a header. No API for managing it that I could see.

zepumph commented 9 months ago

Ok, that wasn't the exact solution, but I did have good luck by setting the Authorization header directly. I just restarted the firefox clients on CT. I'll mark this as review.

zepumph commented 9 months ago

I haven't gotten bayes clients up and running yet, but I can look into that later, as a separate issue.

zepumph commented 9 months ago

We are getting an API CT error now that we are using Firefox again, I'll investigate later.

zepumph commented 9 months ago

I believe this is working well, but I'd like to do one more test to make sure. before closing. I see a few blank spots in the migration testing, I want to make sure there aren't problems.

zepumph commented 9 months ago

zepumph commented 8 months ago

I did more investigation and couldn't find any problems related to authentication. I believe these blank spots are due to webgl, and will be handled in https://github.com/phetsims/aqua/issues/201. Closing