phetsims / aqua

Automatic QUality Assurance
MIT License
2 stars 4 forks source link

fuzz-lightyear should support running phet-io wrappers #190

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

This is blocking migration work because it is untenable to use only CT to report the problems we are encountering.

zepumph commented 1 year ago
zepumph commented 1 year ago

I am so happy now that we removed the build related logic. Now we get much better highlighting when we succeed. image

I would like to ask @samreid about what wrappers we might want to support here. Right now it is just migration and studio.

zepumph commented 1 year ago
zepumph commented 1 year ago

I would like to do a couple more things here:

phet-dev commented 1 year ago

Reopening because there is a TODO marked for this issue.

samreid commented 1 year ago

Here is the existing TODO:

              // TODO: some older sims don't support ?wrapperContinuousTest and so we are loaded if just the first goes. https://github.com/phetsims/aqua/issues/190
              // To also support the basic 'load' event to match the language of the sims
              window.parent && window.parent.postMessage( JSON.stringify( {
                type: 'load',
                url: window.location.href
              } ), '*' );

I'm not really sure how it should be addressed.

zepumph commented 1 year ago

I think if we MR'd support for continuous-test-wrapper-load for the oldest of our migration support wrappers then we would be able to solve this todo (getting rid of this postMessage) AND potentially fix the issue we have a better solution for https://github.com/phetsims/phet-io-wrappers/issues/507. At the very least, perhaps we should rely on wrapperContinuousTest as a parameter for the migration wrapper to squeeze out load events from both studio versions. That way we never ask for an upstream state prematurely.

zepumph commented 1 year ago

Discussed with @jbphet @samreid. While we are at it, we should make sure to rewrite the migrate.js code to always listen to the wrapperContinuousTest logic to achieve the "have both studios loaded". Perhaps we should have an MR for it and create a new issue.

zepumph commented 1 year ago

This will be done in https://github.com/phetsims/phet-io-wrappers/issues/507, closing.