search

phetsims / aqua

Automatic QUality Assurance
MIT License
2 stars 4 forks source link

CT: filter based on "NOT" present #192

Open zepumph opened 1 year ago

zepumph commented 1 year ago

From dev meeting today

I think that if the term starts with a !, then we say that it !includes().

zepumph commented 1 year ago

I got a temp solution working here, but it doesn't AND terms together correctly.

Working: !migration will correctly ignore all tests/messages with "migration" in it

Not Working: !migration -> will show all tests, since every test that has "migration" in it also has "->" in it.

@marlitas, please feel free to use the ! prefix with single words though! I'll get back to this when I can, but it will involve rewriting our filtering logic to remember a precedent for "I specifically told you not to include this thing".

marlitas commented 1 year ago

This is so amazing and cool. Thanks @zepumph!

zepumph commented 1 year ago

Ugg, I think I need to keep working on this, it doesn't work at filtering out content in the error message. I want to use this feature more than it currently supports. Reassigning.