phetsims / aqua

Automatic QUality Assurance
MIT License
2 stars 4 forks source link

CT: [PAGE ERROR] Error: SyntaxError: The requested module 'X.js' does not provide an export named 'default' #195

Closed zepumph closed 10 months ago

zepumph commented 11 months ago

This comes up a fair bit. @samreid and I discussed and feel like this is likely about race conditions in chipper dist. There are potentially multiple processes at once that are transpiling into that directory and reading from it.

Some places to investigate:

zepumph commented 10 months ago

I'd like to run a quick test here where we ask CT to not transpile. I think it will be a pretty simple job and then we can test to see if that cleans up CT.

zepumph commented 10 months ago

I added flags to opt out of transpile and tsc (while I was at it), and then updates CT to use them. Let's see how things go.

zepumph commented 10 months ago

In builds CT also get's errors like:

Error in fulfilling chunk Promise: [Error: TypeError: Yn(...) is not a function
at new zn (http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1035:588885)
at 733 (http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1035:880825)
at i (http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1035:1143250)
at http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1035:1144009
at http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1035:2328403
at phet.chipper.runWebpack (http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1035:2328407)
at i (http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1036:1052)
at t (http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1036:1080)
at http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1036:1105
at http://localhost:38227/circuit-construction-kit-ac/build/phet-io/circuit-construction-kit-ac_all_phet-io.html?ea&brand=phet-io&phetioStandalone&phetioPrintAPI&randomSeed=332211&locales=*:1036:1207]
Snapshot from 9/22/2023, 12:04:26 PM

I think this may be similar chipper/dist race conditions, and I will report back if CT shows any of these problems after the above fix. I don't think it will though.

zepumph commented 10 months ago

I haven't seen any of these errors in the last 2 days, whereas they were in about ~50% of columns before. Yay! @samreid can you please review the commits and see if there is anything else you can think of here?

samreid commented 10 months ago

This seems to be working well, thanks! The main part for me would be to document https://github.com/phetsims/aqua/commit/9634caffb43a7de8bf273e09ae4c1526eedee77d and describe what other process is responsible for the parts that are opting-out here. How can we be confident the other process solved those parts beforehand?

zepumph commented 10 months ago

Yeah good idea thanks. Closing