search

phetsims / aqua

Automatic QUality Assurance
MIT License
2 stars 4 forks source link

CT: runTest should use PERENNIAL/browserPageLoad #198

Closed zepumph closed 9 months ago

zepumph commented 9 months ago

These two files have incredibly similar implementations and in fact they are starting to deviate. Let's bring them closer together.

zepumph commented 9 months ago

I found this while working on https://github.com/phetsims/calculus-grapher/issues/337 because it was hard to reproduce locally. runTest requires too much CT-specific info, and puppeteerLoad didn't have authentication set up (needed for migration testing).

zepumph commented 9 months ago

That went pretty well! It was such a mess in there, I'm glad we could combine them now instead of waiting even longer. I made much of the logic CT centric, like for example how the logging occurs. I tested playwright and puppeteer outside of CT, and the CT process, and all looks really great. I think we are ready to close, but I'd like to wait for a couple of rounds on CT before that.

zepumph commented 9 months ago

Looks to be running great. Closing