search

phetsims / area-builder

"Area Builder" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/area-builder
GNU General Public License v3.0
1 stars 2 forks source link

replace usages of Property.once() #104

Closed jbphet closed 6 years ago

jbphet commented 7 years ago

We have decided to remove support for Property.once(). This simulation is the only one that uses it, so usages should be replaced with alternatives. The parent issue is https://github.com/phetsims/axon/issues/129.

Once done, I should remove once from Property.js.

jbphet commented 6 years ago

I've removed the usages of Property.once from Area Builder, then removed the definition from Property.js. I also removed Events.once from Events.js, just to be thorough and make sure there are no usages of .once() our sim code. I verified that the Axon and Scenery unit tests passed after doing this, and also spot checked a handful of simulations.

Assigning to @samreid to inspect the changes, especially the ones to axon/tests/quint/js/events.js (I was a bit less confident about these).

samreid commented 6 years ago

Skimming the change sets, searching for .once( and checking bayes all seem promising, thanks. Closing.