search

phetsims / area-builder

"Area Builder" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/area-builder
GNU General Public License v3.0
1 stars 2 forks source link

sim relies on align:'right' default for Panels #99

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at createIcon (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/BoardDisplayModePanel.js?bust=1472164614598:35:12)
    at new BoardDisplayModePanel (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/BoardDisplayModePanel.js?bust=1472164614598:44:27)
    at new AreaBuilderExploreView (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/AreaBuilderExploreView.js?bust=1472164614598:64:23)
    at AreaBuilderExploreScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/explore/AreaBuilderExploreScreen.js?bust=1472164614598:35:34)
    at AreaBuilderExploreScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderExploreScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
VM10249 Panel.js?bust=1472164614598:53

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at createIcon (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/BoardDisplayModePanel.js?bust=1472164614598:35:12)
    at new BoardDisplayModePanel (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/BoardDisplayModePanel.js?bust=1472164614598:52:11)
    at new AreaBuilderExploreView (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/AreaBuilderExploreView.js?bust=1472164614598:64:23)
    at AreaBuilderExploreScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/explore/AreaBuilderExploreScreen.js?bust=1472164614598:35:34)
    at AreaBuilderExploreScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderExploreScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
VM10249 Panel.js?bust=1472164614598:53

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at createIcon (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/BoardDisplayModePanel.js?bust=1472164614598:35:12)
    at new BoardDisplayModePanel (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/BoardDisplayModePanel.js?bust=1472164614598:57:11)
    at new AreaBuilderExploreView (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/AreaBuilderExploreView.js?bust=1472164614598:64:23)
    at AreaBuilderExploreScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/explore/AreaBuilderExploreScreen.js?bust=1472164614598:35:34)
    at AreaBuilderExploreScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderExploreScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
VM10249 Panel.js?bust=1472164614598:53

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at BoardDisplayModePanel.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at new BoardDisplayModePanel (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/BoardDisplayModePanel.js?bust=1472164614598:68:11)
    at new AreaBuilderExploreView (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/AreaBuilderExploreView.js?bust=1472164614598:64:23)
    at AreaBuilderExploreScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/explore/AreaBuilderExploreScreen.js?bust=1472164614598:35:34)
    at AreaBuilderExploreScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderExploreScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
    at http://localhost/~cmalley/GitHub/area-builder/js/area-builder-main.js?bust=1472164614598:35:5
VM10249 Panel.js?bust=1472164614598:53

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at new AreaBuilderControlPanel (http://localhost/~cmalley/GitHub/area-builder/js/common/view/AreaBuilderControlPanel.js?bust=1472164614598:58:20)
    at new AreaBuilderExploreView (http://localhost/~cmalley/GitHub/area-builder/js/explore/view/AreaBuilderExploreView.js?bust=1472164614598:68:24)
    at AreaBuilderExploreScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/explore/AreaBuilderExploreScreen.js?bust=1472164614598:35:34)
    at AreaBuilderExploreScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderExploreScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
    at http://localhost/~cmalley/GitHub/area-builder/js/area-builder-main.js?bust=1472164614598:35:5
VM10249 Panel.js?bust=1472164614598:53

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at YouBuiltWindow.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at YouBuiltWindow.FeedbackWindow [as constructor] (http://localhost/~cmalley/GitHub/area-builder/js/game/view/FeedbackWindow.js?bust=1472164614598:54:11)
    at new YouBuiltWindow (http://localhost/~cmalley/GitHub/area-builder/js/game/view/YouBuiltWindow.js?bust=1472164614598:39:20)
    at new AreaBuilderGameView (http://localhost/~cmalley/GitHub/area-builder/js/game/view/AreaBuilderGameView.js?bust=1472164614598:154:27)
    at AreaBuilderGameScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/game/AreaBuilderGameScreen.js?bust=1472164614598:35:34)
    at AreaBuilderGameScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderGameScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
VM10249 Panel.js?bust=1472164614598:53

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at YouEnteredWindow.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at YouEnteredWindow.FeedbackWindow [as constructor] (http://localhost/~cmalley/GitHub/area-builder/js/game/view/FeedbackWindow.js?bust=1472164614598:54:11)
    at new YouEnteredWindow (http://localhost/~cmalley/GitHub/area-builder/js/game/view/YouEnteredWindow.js?bust=1472164614598:34:20)
    at new AreaBuilderGameView (http://localhost/~cmalley/GitHub/area-builder/js/game/view/AreaBuilderGameView.js?bust=1472164614598:156:29)
    at AreaBuilderGameScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/game/AreaBuilderGameScreen.js?bust=1472164614598:35:34)
    at AreaBuilderGameScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderGameScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
VM10249 Panel.js?bust=1472164614598:53

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at new AreaBuilderControlPanel (http://localhost/~cmalley/GitHub/area-builder/js/common/view/AreaBuilderControlPanel.js?bust=1472164614598:58:20)
    at new AreaBuilderGameView (http://localhost/~cmalley/GitHub/area-builder/js/game/view/AreaBuilderGameView.js?bust=1472164614598:170:25)
    at AreaBuilderGameScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/game/AreaBuilderGameScreen.js?bust=1472164614598:35:34)
    at AreaBuilderGameScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderGameScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
    at http://localhost/~cmalley/GitHub/area-builder/js/area-builder-main.js?bust=1472164614598:35:5
VM10249 Panel.js?bust=1472164614598:53

>>>> sim relies on align:right
VM10249 Panel.js?bust=1472164614598:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164614598:50:15)
    at new AreaBuilderGameView (http://localhost/~cmalley/GitHub/area-builder/js/game/view/AreaBuilderGameView.js?bust=1472164614598:218:29)
    at AreaBuilderGameScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/area-builder/js/game/AreaBuilderGameScreen.js?bust=1472164614598:35:34)
    at AreaBuilderGameScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:134:25)
    at AreaBuilderGameScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164614598:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164614598:439:13)
    at http://localhost/~cmalley/GitHub/area-builder/js/area-builder-main.js?bust=1472164614598:35:5
    at window.phetLaunchSimulation (http://localhost/~cmalley/GitHub/joist/js/SimLauncher.js?bust=1472164614598:54:11)
pixelzoom commented 8 years ago

None of the above call sites use the minWidth option, so their behavior will be unaffected. Closing.