search

phetsims / area-model-common

Code common to Area Model simulations
GNU General Public License v3.0
0 stars 1 forks source link

Axon Properties should end in `Property` suffix #169

Closed samreid closed 6 years ago

samreid commented 6 years ago

Discovered during https://github.com/phetsims/tambo/issues/46, I saw that Area Model Common had a few axon Properties that didn't end with a Property suffix:

AreaModelCommonModel.js

    // @public {Property.<boolean>}
    this.factorsBoxExpanded = new BooleanProperty( true );

    // @public {Property.<boolean>}
    this.areaBoxExpanded = new BooleanProperty( options.initialAreaBoxExpanded );

I'm not sure whether or not there are others. Generally it is best if axon Properties end in the suffix Property. Also, PhET-iO tandems require a Property suffix for Property types.

jonathanolson commented 6 years ago

Whoops, sorry!

Should be fixed in the above commit. I checked for = new Property, = new BooleanProperty, and = new NumberProperty and didn't see any other cases.

Can you verify?

samreid commented 6 years ago

Looks great, thanks @jonathanolson!