search

phetsims / arithmetic

"Arithmetic" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/arithmetic
GNU General Public License v3.0
5 stars 5 forks source link

Type error in automated testing #137

Closed jonathanolson closed 9 years ago

jonathanolson commented 9 years ago 
Uncaught TypeError: Cannot read property 'currentScore' of undefined
TypeError: Cannot read property 'currentScore' of undefined
    at MultiplyModel.inherit.saveGameEnvironment (http://192.168.0.2:8080/arithmetic/js/common/model/ArithmeticModel.js?bust=1436389424684:385:45)
    at MultiplyModel.inherit.returnToLevelSelectScreen (http://192.168.0.2:8080/arithmetic/js/common/model/ArithmeticModel.js?bust=1436389424684:185:12)
    at WorkspaceNode.addChild.BackButton.listener (http://192.168.0.2:8080/arithmetic/js/common/view/WorkspaceNode.js?bust=1436389424684:58:17)
    at http://192.168.0.2:8080/sun/js/buttons/PushButtonModel.js?bust=1436389424684:126:9
    at Array.forEach (native)
    at PushButtonModel.inherit.fire (http://192.168.0.2:8080/sun/js/buttons/PushButtonModel.js?bust=1436389424684:125:12)
    at http://192.168.0.2:8080/sun/js/buttons/PushButtonModel.js?bust=1436389424684:72:25
    at Array.onValueObserver (http://192.168.0.2:8080/axon/js/Property.js?bust=1436389424684:276:13)
    at Property.inherit._notifyObservers (http://192.168.0.2:8080/axon/js/Property.js?bust=1436389424684:112:29)
    at Property.inherit._setAndNotifyObservers (http://192.168.0.2:8080/axon/js/Property.js?bust=1436389424684:99:14)
    at Property.inherit.set (http://192.168.0.2:8080/axon/js/Property.js?bust=1436389424684:72:16)
jbphet commented 9 years ago

This issue was caused when certain controls were clicked when the workspace node was animating into place. I tried to duplicate manually, and it was basically impossible with a mouse to hit the moving targets, but maybe it would come up on a touch device with multiple individuals trying to interact with the sim. At any rate, I've changed the code such that the level selection screen and the workspace are made unpickable while animating. I then ran the fuzzMouse=100 test on two machines simultaneously for about 45 min, and no errors occurred. I also ran the test-server, and it gave this sim a green light. As best I can tell, this issues is addressed. Closing.