Convert from TWEEN to Twixt

phetsims / arithmetic

"Arithmetic" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/arithmetic

GNU General Public License v3.0

5 stars 5 forks source link

Convert from TWEEN to Twixt #184

Closed samreid closed 5 years ago

samreid commented 6 years ago

As discussed in https://github.com/phetsims/joist/issues/387#issuecomment-419600722, it would be nice to use Twixt instead of TWEEN. This sim has 3 occurrences of new TWEEN.Tween(...). Assigning to the responsible dev. After completing this issue, check if the hold on https://github.com/phetsims/joist/issues/387 can be removed (if this was the last "Convert from TWEEN to Twixt" issue).

jbphet commented 5 years ago

Usages replaced (which involved some rewriting), preloads removed. Tested the animations manually and via fuzz testing. Did a basic memory leak test and didn't see anything that appeared to be related to the new animations. Should be good to go, closing.