Decide whether to turn off UI sounds on next publication

phetsims / arithmetic

"Arithmetic" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/arithmetic

GNU General Public License v3.0

5 stars 5 forks source link

Decide whether to turn off UI sounds on next publication #194

Closed markgammon closed 6 months ago

markgammon commented 2 years ago

As part of the work done for https://github.com/phetsims/vegas/issues/77, UI sounds got turned on for this simulation. Before the sim is published again from master, we should decide whether to turn the UI sounds off, leave them on and design and implement sounds for the rest of the interactions, or publish with a partial sound design.

If the decision is to turn them off, this can be accomplished by adding the following line to the end of the sim's -main.js file:

  soundManager.setOutputLevelForCategory( 'user-interface', 0 );

marlitas commented 7 months ago

I am assuming completing sound design is not part of the work that should be included in the upcoming region and culture publication. I'll self assign to turn off. @kathy-phet let me know if I assumed incorrectly and we will be adding sound to this sim.

amanda-phet commented 7 months ago

I just used the sim and I think UI sounds on might be ok... Normally I don't like UI sounds because the primary interactions can end up being totally silent, but for this sim the only "silent" interaction is on the factor levels. All other primary interactions have sounds, since they are directly with buttons.

The factor level interaction is already a little strange and I'm not sure a sound would make sense to add. The moment you click the square you get a feedback sound. So, in sum, I think all of the UI sounds could be added and not cause any problems!

The only sound I would really like to change is the "refresh" button. It would be nice if it had a reset-ish sound, since that's what that button does. Perhaps the sound we are using for eraser buttons would work.

marlitas commented 7 months ago

Okay great. We might be able to just use the eraser sound from CAV then to not go through any sound design stuff since that got approved already. I'll start with adding that in and we can go from there.

AgustinVallejo commented 7 months ago

In the above commit I changed the default RefreshButton sound for the new eraser sound. Assigning back to @marlitas for her (or somebody else) to make sure it's what you guys wanted.

AgustinVallejo commented 7 months ago

@amanda-phet commented on Slack:

Yes, I think it would be a nice update to replace that button with the eraser button!

Will do

AgustinVallejo commented 7 months ago

Added the requested changes. The only thing that seems off is the spacing inside the Panel, which seems different to the published version. I'm adding screenshots for published, main branch before the above commits, and main branch after commits.

@marlitas @amanda-phet Please review these changes and let me know if something should be done about that spacing.

amanda-phet commented 6 months ago

Eraser button looks and sounds good!