search

phetsims / arithmetic

"Arithmetic" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/arithmetic
GNU General Public License v3.0
5 stars 5 forks source link

Replace NumberKeypad with Keypad #200

Closed pixelzoom closed 9 months ago

pixelzoom commented 9 months ago

Since work is being done on this sim... From https://github.com/phetsims/arithmetic/issues/7#issuecomment-1858370303:

In our design discussion today, we also noted that arithmetic is using NumberKeypad, which is deprecated. It's the last sim to be using it, so it would be really great to convert to Keypad (the new solutions) so that we can delete NumberKeypad.

marlitas commented 9 months ago

This has been addressed in the above commit. Over to @Luisav1 or @AgustinVallejo for review.

AgustinVallejo commented 9 months ago

Looks like a clean fix to me! Closing

pixelzoom commented 9 months ago

I was hoping that NumberKeypad could now be deleted. But I see that it's used in NumberEntryControl, which is used in area-builder and make-a-ten.