search

phetsims / arithmetic

"Arithmetic" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/arithmetic
GNU General Public License v3.0
5 stars 5 forks source link

Convert to new approach for Region and Culture #215

Closed Luisav1 closed 6 months ago

Luisav1 commented 6 months ago

For https://github.com/phetsims/joist/issues/958.

The changes were done in https://github.com/phetsims/arithmetic/commit/970fe8bea109c48197d4b409747599138393ce1c.

@amanda-phet This needs a design review to ensure the Region and Culture changes were alright. The changes can be seen in main.

amanda-phet commented 6 months ago

The preferences dialog looks how I would expect. Query parameter is working.

Can we make random the default selection for Region & Culture?

Luisav1 commented 6 months ago

Although the default in general for R&C is usa (from https://github.com/phetsims/joist/issues/957#issue-2174982628), @amanda-phet confirmed with @kathy-phet that we'll use random as the default when the usa set is only one character, such as this sim.

Oops, I missed #214 that is tracking changing the default to random.

Luisav1 commented 6 months ago

Closing since this has been reviewed and #214 set the default to random.