phetsims / atomic-interactions

"Atomic Interactions" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

Horizontal adjustment arrow doesn't always stay with graph #34

Closed ycarpenterphet closed 8 years ago

ycarpenterphet commented 9 years ago

This is an existing issue in the Java sim, and has been carried through to the HTML5.

In the Custom Attraction mode, if the interaction strength is adjusted to be very small, the horizontal adjustment arrow is now floating and not attached to the curve: screen shot 2015-03-03 at 4 08 09 pm

This isn't ideal behaviour (it's best if the control stayed attached to the thing it controls), but is relatively low priority to fix.

Note that we're also likely moving the horizontal arrow control higher on the curve (see #24), so that may affect the position too.

ycarpenterphet commented 9 years ago

Clarification - the position of the horizontal adjustment arrow is set by the value of sigma, since that's literally what it adjusts. We'll have to make a decision as to whether the horizontal arrow control should be longer, so that it stays with the curve too, especially if we move it higher up vertically to solve #24.

I'll try out a couple of options once we solve #24 to see which works best, before we make a decision on this one. For now, let's do nothing about this issue.

Tagging @arouinfar since this will affect States of Matter too.

ycarpenterphet commented 9 years ago

Flagging this as something for @arouinfar to watch for in interviews - if there are no issues in interview with the interface as is, we can close this issue.

ycarpenterphet commented 9 years ago

This is much improved now that the adjustment arrows are larger. Likely won't be an issue.

arouinfar commented 8 years ago

It looks like this issue has already been resolved. The horizontal adjustment arrow stays tied to the curve, and has a generous touch area.

image image

I'm going to go ahead and close this issue. If something arises in interviews, we can revisit.