search

phetsims / atomic-interactions

"Atomic Interactions" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

sim relies on align:'right' default for Panels #57

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim uses Panel option minWidth relies on the old default of align:'right'. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM10886 Panel.js?bust=1472164642115:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164642115:50:15)
    at new AtomicInteractionsControlPanel (http://localhost/~cmalley/GitHub/states-of-matter/js/atomic-interactions/view/AtomicInteractionsControlPanel.js?bust=1472164642115:386:28)
    at new AtomicInteractionsScreenView (http://localhost/~cmalley/GitHub/states-of-matter/js/atomic-interactions/view/AtomicInteractionsScreenView.js?bust=1472164642115:78:42)
    at AtomicInteractionsScreen.createView (http://localhost/~cmalley/GitHub/states-of-matter/js/atomic-interactions/AtomicInteractionsScreen.js?bust=1472164642115:32:34)
    at AtomicInteractionsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164642115:134:25)
    at AtomicInteractionsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164642115:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164642115:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164642115:439:13)
    at http://localhost/~cmalley/GitHub/atomic-interactions/js/atomic-interactions-main.js?
pixelzoom commented 8 years ago

I believe this sim may be a subset of states-of-matter, so this may be a duplicate of https://github.com/phetsims/states-of-matter/issues/146.

pixelzoom commented 8 years ago

Visually inspected and compared to previous dev versions, I see no change. @jbphet up to you whether you want to inspect further or close.

jbphet commented 8 years ago

I checked this out on both the AI and SOM sims with the default English strings, and then tested with long and short strings, and the AtomicInteractionsControlPanel looked fine. Closing.