phetsims / atomic-interactions

"Atomic Interactions" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

Size and alignment of "Pinned" and "Moving" labels does not match spec #6

Closed ycarpenterphet closed 9 years ago

ycarpenterphet commented 9 years ago

The design document shows the following, where the heading fonts are significantly smaller than the radio button label font: screen shot 2015-02-25 at 4 53 08 pm

Please... (1) Adjust the size and position of the pin graphic to match the design (2) Reduce the font size for the 'Pinned' and 'Moving' labels to match the design (3) Adjust the alignment of these labels (so that they are left aligned with the column below, as shown in the design document). (4) If possible, more closely match the spacing between columns shown in the design.

pixelzoom commented 9 years ago

Clearly not fixed in a general way that supports i18n. Here's what it looks like when 'XXX' is added to the 'Pinned' and 'Moving' labels:

screenshot_225

ChandrashekarBemagoni commented 9 years ago

Fixed in above commits.Assigning to @ycarpenterphet for verification

ycarpenterphet commented 9 years ago

The size and alignment don't quite match the mockup yet:

Design document: screen shot 2015-03-05 at 1 07 23 pm

Current sim: screen shot 2015-03-05 at 1 10 52 pm

Note especially the spacing between the top of the menu and the pinned/moving text, and the size of the pin.

ChandrashekarBemagoni commented 9 years ago

Fixed in above commits . Assigning to @ycarpenterphet for verification

ycarpenterphet commented 9 years ago

Looks good. Closing.