search

phetsims / atomic-interactions

"Atomic Interactions" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 2 forks source link

Force Arrows remain when atom changes #76

Closed KatieWoe closed 5 years ago

KatieWoe commented 6 years ago

Test device: Dell Laptop Operating System: Win 8.1 and 10 Browser: Firefox and Chrome Problem description: For https://github.com/phetsims/QA/issues/216. In published version and States of Matter. May be connected to https://github.com/phetsims/atomic-interactions/issues/36. When the sim is paused when force arrows are visible, and the atoms are changed while paused, the same arrows remain. When the atoms are changed normally, any movement stops and net force is zero. In this case, the atoms are in their proper place, but the arrows have not updated. Steps to reproduce: !. Turn on total force

  1. Set the atom moving
  2. Pause the sim when the force in non-zero
  3. While paused, select another atom combination

Screenshots: bigarrow

Troubleshooting information (do not edit):

Name: ‪Atomic Interactions‬ URL: https://phet-dev.colorado.edu/html/atomic-interactions/1.1.0-rc.1/phet/atomic-interactions_en_phet.html Version: 1.1.0-rc.1 2018-11-05 21:18:48 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36 Language: en-US Window: 1536x732 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {"assert":{"sha":"928741cf","branch":"HEAD"},"atomic-interactions":{"sha":"15bb3a2d","branch":"HEAD"},"axon":{"sha":"d7ba44e2","branch":"HEAD"},"brand":{"sha":"89d28f63","branch":"HEAD"},"chipper":{"sha":"bbbb514a","branch":"HEAD"},"dot":{"sha":"820111c8","branch":"HEAD"},"joist":{"sha":"749f10ff","branch":"HEAD"},"kite":{"sha":"59755f7e","branch":"HEAD"},"nitroglycerin":{"sha":"ccaab9cd","branch":"HEAD"},"phet-core":{"sha":"68a89cc4","branch":"HEAD"},"phet-io":{"sha":"364077cf","branch":"HEAD"},"phet-io-wrapper-classroom-activity":{"sha":"abc4ae3e","branch":"HEAD"},"phet-io-wrapper-hookes-law-energy":{"sha":"429886e7","branch":"HEAD"},"phet-io-wrapper-lab-book":{"sha":"ef0b0b0c","branch":"HEAD"},"phet-io-wrappers":{"sha":"7ec1a04a","branch":"HEAD"},"phetcommon":{"sha":"22b158d0","branch":"HEAD"},"query-string-machine":{"sha":"c2e502fb","branch":"HEAD"},"scenery":{"sha":"415371c3","branch":"HEAD"},"scenery-phet":{"sha":"94b92879","branch":"HEAD"},"sherpa":{"sha":"a9fd066b","branch":"HEAD"},"states-of-matter":{"sha":"d6317e0b","branch":"HEAD"},"sun":{"sha":"3086e97a","branch":"HEAD"},"tambo":{"sha":"0e5b9133","branch":"HEAD"},"tandem":{"sha":"a2348c0c","branch":"HEAD"}}
jbphet commented 5 years ago

Unassigning until this sim comes back to my list of top priorities.

SaurabhTotey commented 5 years ago

I believe I have now addressed this issue in the latest commit.

SaurabhTotey commented 5 years ago

Removing status:ready-for-review label and assigning to @KatieWoe to review.

KatieWoe commented 5 years ago

This does look good in master.

SaurabhTotey commented 5 years ago

Sounds good. I'll unassign and add a status:fixed-awaiting-deploy label.

SaurabhTotey commented 5 years ago

Doesn't seem to exist on deployed version. Closing.