search

phetsims / axon

Axon provides powerful and concise models for interactive simulations, based on observable Properties and related patterns.
MIT License
11 stars 8 forks source link

Remove NumberProperty.step? #386

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

Over in https://github.com/phetsims/studio/issues/245 we got rid of sliders as a UI control for Properties in PhET-iO studio. This means that the step option is no longer used in studio. Should we remove this? Does it serve any other purpose? It isn't part of the validation when the NumberProperty is set, it is just part of the metadata when the instance is created. If it sticks around, it should likely be part of validation.

@samreid can we remove this option though?

samreid commented 2 years ago

Yes, it should be removed. I'll do so momentarily.

samreid commented 2 years ago

Removed, can you please review?

zepumph commented 2 years ago

This is great. Thanks!