search

phetsims / axon

Axon provides powerful and concise models for interactive simulations, based on observable Properties and related patterns.
MIT License
10 stars 8 forks source link

getArrayCopy was removed from createObservableArray, but it was being used, and CT is failing #392

Closed jbphet closed 2 years ago

jbphet commented 2 years ago

In this commit the function getArrayCopy was removed from createObservableArray https://github.com/phetsims/axon/commit/5b5880392cbf8f827b1ef2b8e071ad975a54dde2.

This is causing CT failures, such as this one:

number-line-distance : fuzz : built
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000
Query: fuzz&memoryLimit=1000
Uncaught TypeError: this.numberLinePoints.getArrayCopy is not a function
TypeError: this.numberLinePoints.getArrayCopy is not a function
at vD.removeClearAndDisposePoints (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:1364841)
at vD.proposePosition (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:1372793)
at qc.drag [as _dragListener] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:1539614)
at qc.drag (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:683756)
at _dragAction.al.parameters.name (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:692271)
at sl.execute (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:552225)
at qc.drag (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:693314)
at qc.pointerMove (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:686554)
at fc.dispatchToListeners (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:661494)
at fc.dispatchEvent (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1650636043985/number-line-distance/build/phet/number-line-distance_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22number-line-distance%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1650636043985%22%2C%22timestamp%22%3A1650640918138%7D&fuzz&memoryLimit=1000:886:661124)
id: Bayes Chrome
Snapshot from 4/22/2022, 8:00:43 AM
zepumph commented 2 years ago

Good catch. Sorry about that. Looks like I deleted a newline