search

phetsims / axon

Axon provides powerful and concise models for interactive simulations, based on observable Properties and related patterns.
MIT License
10 stars 8 forks source link

Review MappedProperty #416

Closed samreid closed 1 year ago

samreid commented 1 year ago

In https://github.com/phetsims/axon/issues/342 there was a TODO to review MappedProperty:

// TODO https://github.com/phetsims/axon/issues/342 this file could use review by @jonathanolson
export default class MappedProperty<ThisValueType, InputValueType> extends DynamicProperty<ThisValueType, InputValueType, TReadOnlyProperty<InputValueType>> {
  public constructor( property: TReadOnlyProperty<InputValueType>, providedOptions?: MappedPropertyOptions<ThisValueType, InputValueType> ) {
    super( new TinyProperty( property ), providedOptions );
  }
}

Reaching out to dev meeting to see if this is still necessary, and who has time for this.

samreid commented 1 year ago

As discovered in https://github.com/phetsims/chipper/issues/946, there are TODOs in the code referring to this issue. Reopening.

samreid commented 1 year ago

Fixed, closing.