search

phetsims / babel

This repo contains the translated strings for PhET's simulations.
MIT License
4 stars 9 forks source link

Investigate removal of a couple es translations #24

Closed zepumph closed 3 months ago

zepumph commented 3 months ago

In https://github.com/phetsims/qa/issues/1098#issuecomment-2181191980, QA found that there was a translator that removed a few spanish strings from preferences. This occurred in https://github.com/phetsims/babel/commit/ffb1a5296f0693b709bfb98dd73082ffd237e6d5. I believe this was a mistake done by a translator, but I don't know how to proceed, since I know we don't do too much translation moderation. I think it may just be good to check in with @DianaTavares, and see if she wants to do a quick translation to add these region and culture strings back in for es. Note that still on main, there are no region and culture strings translated for es, and I don't know if there is context I'm missing, or if this is purposeful. My guess is that it isn't purposeful.

@DianaTavares, let me know if you want to discuss async.

zepumph commented 3 months ago

Looks like in CAV 1.1, the translations were coming from soccer common: https://github.com/phetsims/soccer-common/commit/75c9aee5a2d34406928ced240512b2163683e393

zepumph commented 3 months ago

In ESP and Number Line: Integers looks like the bug has come from changing the joist strings. This is what they are expecting:

 "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.africa": "‪Africa‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.africaModest": "‪Africa (Modest)‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.asia": "‪Asia‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.latinAmerica": "‪Latin America‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.oceania": "‪Oceania‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.unitedStatesOfAmerica": "‪United States of America‬",

Broke on 3/14/24: https://github.com/phetsims/joist/commit/700195e11694eeda4e33a1951af8e06df89cd98f

zepumph commented 3 months ago

I think I'd like to create a script that looks at all the string keys needed in a sim and ensures they all live on the main still (for common code only). I'll see how that goes. (good luck me).

DianaTavares commented 3 months ago

CM share this list of sims that have region and culture: screenshot_3393_480

I review if those sims also have this problem: Area Model Algebra: it is ok! Area Model multiplication: it is ok! balancing-act: it is ok with those strings, but indicating that is not 100%, but al strings are translated. energy-skate.park-basics: I don't know why it is on the list, it doesn't have region and culture, same for F&M:B Graphing-lines: : it is ok! Graphing-slope-intersept: it is ok! both number line: it is ok!

zepumph commented 3 months ago

Thanks for the report. I believe nothing more is needed here, and everything will proceed from https://github.com/phetsims/chipper/issues/1446, as well as the language title and description over in https://github.com/phetsims/joist/issues/976. Closing