phetsims / balancing-chemical-equations

"Balancing Chemical Equations" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/balancing-chemical-equations
GNU General Public License v3.0
2 stars 5 forks source link

sim relies on align:'right' default for Panels #115

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM11819 Panel.js?bust=1472164686081:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164686081:50:15)
    at new ControlPanel (http://localhost/~cmalley/GitHub/balloons-and-static-electricity/js/balloons-and-static-electricity/view/ControlPanel.js?bust=1472164686081:145:19)
    at new BalloonsAndStaticElectricityView (http://localhost/~cmalley/GitHub/balloons-and-static-electricity/js/balloon…ctricity/view/BalloonsAndStaticElectricityView.js?bust=1472164686081:49:20)
    at Screen.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/balloons-and-static-electricity/js/balloons-and-static-electricity-main.js?bust=1472164686081:37:35)
    at Screen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164686081:134:25)
    at Screen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164686081:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164686081:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164686081:439:13)
pixelzoom commented 8 years ago

Created issue for wrong sim, moved to https://github.com/phetsims/balloons-and-static-electricity/issues/162.

Closing.