search

phetsims / balancing-chemical-equations

"Balancing Chemical Equations" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/balancing-chemical-equations
GNU General Public License v3.0
2 stars 5 forks source link

replace Unicode check marker and X with font-awesome icons #120

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

See https://github.com/phetsims/unit-rates/issues/180

pixelzoom commented 7 years ago

Done, screenshots below.

@amanda-phet since you're reviewing this same change for graphing-lines (https://github.com/phetsims/graphing-lines) would you mind reviewing this one too? Let me know if the screenshot isn't sufficient and you need a dev version.

screenshot_309

screenshot_310

pixelzoom commented 7 years ago

Btw... yes, the color of the check mark in this sim really is 'yellow', I didn't change it. (It's green in graphing lines.) Here's a screenshot of the published version:

screenshot_311

amanda-phet commented 7 years ago

Btw... yes, the color of the check mark in this sim really is 'yellow', I didn't change it.

I was going to ask... it doesn't look right, and the original check with the drop shadow looks better in yellow. Should we change it to green?

pixelzoom commented 7 years ago

Trivial to change it to green, and I agree that green would look better. But your call @amanda-phet.

pixelzoom commented 7 years ago

@amanda-phet Here's a screenshot showing how it balancing-chemical-equations would look with the same green used in graphing-lines,'rgb( 0, 180, 0 )'.

screenshot_312

amanda-phet commented 7 years ago

I like the green better since there is no shadow behind the check.

pixelzoom commented 7 years ago

Done.

Discussed with @amanda-phet, this does not warrant a maintenance release. It will be picked up the next time we create a release branch.

Closing.