search

phetsims / balloons-and-static-electricity

"Balloons and Static Electricity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/balloons-and-static-electricity
GNU General Public License v3.0
6 stars 10 forks source link

Pressing spacebar on the balloon button causes other option to look pressed #435

Closed jessegreenberg closed 5 years ago

jessegreenberg commented 5 years ago

Very likely after changes for https://github.com/phetsims/scenery/issues/888

jessegreenberg commented 5 years ago

There are old accessibility listeners for keydown/keyup which are on DownListener. These are now handled by scenery because addInputListener adds these a11y listeners too. Can these be removed from DownUpListener? And why isn't this happening for all things that use DownUpListener like checkbox?

jessegreenberg commented 5 years ago

And why isn't this happening for all things that use DownUpListener like checkbox?

The listeners are being called in DownUpListener, but ButtonListener is what updates the state of the checkbox and its functions aren't being called from the a11y listeners.

I think these should be removed from DownUpListener. A11y button behavior has been moved to PressListener.

jessegreenberg commented 5 years ago

This has been fixed.