search

phetsims / balloons-and-static-electricity

"Balloons and Static Electricity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/balloons-and-static-electricity
GNU General Public License v3.0
6 stars 10 forks source link

Simplify BalloonNode constructor args #437

Closed jessegreenberg closed 5 years ago

jessegreenberg commented 5 years ago

I wonder if args can be removed from the BalloonNode constructor, there are quite a few.

I also don't understand why x and y are passed to the constructor and set with 

    this.x = x;
    this.y = y;

but then the node gets a translation from the model Property right after. I bet these can be removed outright, removing two args from the constructor right away.

jessegreenberg commented 5 years ago

Done above