phetsims / balloons-and-static-electricity

"Balloons and Static Electricity" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/balloons-and-static-electricity
GNU General Public License v3.0
6 stars 10 forks source link

Investigate how to hear "Released." more consistently #453

Closed terracoda closed 5 years ago

terracoda commented 5 years ago

In https://github.com/phetsims/balloons-and-static-electricity/issues/452#issuecomment-544773613

I noticed I didn't hear the "Released." on every release interaction.

I think we did things differently in Friction.

If time, I'd like to investigate how to improve this for a future maintenance release of BASE.

It may or may not be easy to parametize the "Released." string and prepend-it to a directional context response.

jessegreenberg commented 5 years ago

This may just be a bug in the code @terracoda, from what I can tell we aren't always putting this alert in the utteranceQueue when we should.

jessegreenberg commented 5 years ago

It is because the "Release" alert is triggered specifically from key presses and blur events - none of which happen on iOS Safari with VoiceOver.

jessegreenberg commented 5 years ago

@terracoda can you see if this is fixed in https://phet-dev.colorado.edu/html/balloons-and-static-electricity/1.5.0-dev.14/phet/balloons-and-static-electricity_en_phet.html?

terracoda commented 5 years ago

Yes, I hear the release alert now! I tested a release from the middle of Play Area and a Release at the wall. I think we can close.