Closed terracoda closed 3 years ago
jessegreenberg
commented
3 years ago We discussed this today at 7/27/21 -
We identified a bug that was preventing the combinded description from being used. Should be fixed in the above commit. @terracoda would you like to verify?
terracoda
commented
3 years ago @jessegreenberg , using PhET Test, I am still seeing some inconsistencies when the balloons are overlapped. Sometimes only the effect of a single balloon is described in the charge movement string.
In the screen shot below, only the green balloon is described as having an effect. This might be because the YB only has 6 charges, and the GB has "many" but I think 6 charges still has a "a little bit" of an effect on their own.
I did another test. It takes 6 charges to make the Yellow balloon actually stick to the wall. So with 6 charges (i.e. "a few") on the YB, and "several" on the GB, I seem to always get the "balloons" as having an induced charge effect when the GB only has "several" rather than "many" more negative charges.
In the screenshot above, the GB has "many", so it seems when one balloon has "a few" and the other "balloon" has many we mihgt not always get the combined effect described.
@jessegreenberg, is this a bug - this difference between "several" and "many"? Can you fine tune things a little bit more to make sure when a balloon has a enough charge to make it stick to the wall that a combined effect is described when the balloons are "next to" each other?
And noting other behaviour: The Wall's induced charge can change between "a little bit" and "quite a lot" of movement depending on how much the balloons overlap and how much negative net charge the balloons have. I think the range in described movement is the intended behaviour. Does that make sense to you, @jessegreenberg?
When the balloons are not described as "next to" each other, only the movement of that single balloon is described. This is the intended behaviour.
terracoda
commented
3 years ago If this fine-tuning is hard, let's quickly discuss. Maybe it's something we can't always capture?
jessegreenberg
commented
3 years ago I tried to reproduce the inconsistencies you mentioned @terracoda but could not. I tried to recreate the same case where the YB has 6 charges:
For both the movement and release alerts it combined them. Is there anything else I am missing while testing?
terracoda
commented
3 years ago @jessegreenberg, I can't reproduce now either. Let's chalk it up to glitch and move on :-)
jessegreenberg
commented
3 years ago Thanks for checking! Very possible changes since https://github.com/phetsims/balloons-and-static-electricity/issues/520#issuecomment-891022918 have resolved this naturally.
While reviewing #490, I noticed that when 2 balloons are in play and against the wall, I get very good combined balloon and induced charge effect descriptions as long as one balloon is grabbed.
But as soon as I both balloons are released, I no longer get the combined "balloons" describe with the combined induced charge effect. I just get a single balloon description with the combined induced charge effect.
When Yellow Balloon is grabbed with a few charges, against wall AND next to Green Balloon. The Context Response and the Wall's dynamic State Description correctly describe the combined induced effect:
However, as soon as I release the Yellow Balloon, I get 2 responses
@jessegreenberg, I know we have worked on this edge case before, so I am not sure if this is new, or if we just decided to do ignore the combined effect on release, or if we missed it.
Regardless, since we are monitoring for a combined induced charge effect when the balloons are active and considered to be next to each other, is there a quick fix for this situation when both balloons are released? For example, is it possible to hear "balloons" rather than "Yellow balloon" alone in the last response (above) after the yellow balloon is released?