search

phetsims / bamboo

Charting library built with Scenery
http://scenerystack.org/
MIT License
3 stars 0 forks source link

ChartTransform enhancements #24

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

ChartTransform has some duplication, and would be nice to have modelToViewXY to avoid having to create a Vector2 to pass to modelToViewPosition, and for symmetry with ModelViewTransform2.

I'll do this.

pixelzoom commented 3 years ago

Done. I added modelToViewXY and fixed some duplication in modelToViewPosition.

Over to @samreid for review.

samreid commented 3 years ago

I reviewed the commits and don't have any recommendations, thanks! Closing.