Closed pixelzoom closed 8 years ago
In https://github.com/phetsims/concentration/issues/47#issuecomment-177034062, @ariel-phet described the priority:
ideally complete next week. This would be top priority, with the understanding that it is bumping function builder priority for next week. I think we could hand a link that is tested, but not yet published on the website.
In https://github.com/phetsims/concentration/issues/47#issuecomment-177034062, @ariel-phet wrote:
For the Solute display, I have some thoughts, but you and I should discuss, and then probably get some opinions from Amy H.
Model changes: • Requires the same model changes as noted in https://github.com/phetsims/beers-law-lab/issues/149#issuecomment-177326987. • See beaker for computation of grams.
View changes: • Put "Solute Amount: XX g" above the "Remove Solute" button. OK to reduce width of Evaporation control if needed.
@ariel-phet will discuss with @amyh-phet whether this feature should always be visible, or hidden behind a query parameter.
The query parameter would be showSoluteAmount
.
Question for @kathy-phet and @ariel-phet .... The current plan is for this feature to apply only to the "Concentration" screen. Is there anything related that needs to be changed in the "Beer's Law" screen? Ie, if I enabled this feature when running the Beer's Law Lab sim, will there be anything inconsistent between the "Concentration" and "Beer's Law" screens if only the Concentration screen displays solute amount in grams?
@ariel-phet How do you want this feature delivered? As a 1.3.1 maintenance release (more work for me), or as a new 1.4 release branch (requires a complete RC test)? ... keeping in mind that recent PhET-iO changes are not in the 1.3 maintenance branch.
@ariel-phet How many decimal places in the displayed value?
In beaker the grams of solute were given as a whole number, so I would think we should round to the nearest whole number for this change request
@ariel-phet Is there anything related to this feature that needs to appear in the PhET-iO data stream? Or is this something that's only visible to the user?
@pixelzoom - my instincts would say that knowing the amount of solute added would be useful in PhET-iO.
I think if the moles of solute is already available for iO that would be fine so long as the grams per mole we were using were was clear. (so it could be easily calculated by the end iO user). But some sort of availability of the amount of solute added at different points seems important. For instance isn't the fact that the solution is saturated somehow reported in the iO data stream?
beers-law-lab-api.js updated in https://github.com/phetsims/together/commit/25cb5d85621cdef7d69e4201e0a80f0d1580efb2, added 2 new Properties:
• soluteGramsProperty (for this issue) • percentConcentrationProperty (for #149)
Dev version is available here:
http://www.colorado.edu/physics/phet/dev/html/beers-law-lab/1.4.0-dev.1/beers-law-lab_en.html
The query parameter is soluteAmountVisible
. It's a boolean query parameter, and follows the convention used by other PhET boolean query parameter. That is, if you provide the query parameter, it's true, if you don't then it's false. If you soluteAmountVisible=false
, that's still going to show the feature. (If you want this behavior changed, create a chipper issue. Otherwise I'm going to follow PhET convention.)
To demonstrate this feature:
http://www.colorado.edu/physics/phet/dev/html/beers-law-lab/1.4.0-dev.1/beers-law-lab_en.html? soluteAmountVisible
Assigned to @ariel-phet for initial feedback.
We should have a chemist review the correctness of the values. I copied what was done in Beaker, and I'm not qualified to verify the correctness of the values.
Btw... On some browsers, the "Solute Amount: X g" string jitters around a little as it's updated. Nothing I can do about that. In order to properly handle i18n order, this is a single string that must be updated as the value changes.
Looking good. @amyh-phet liked the placement of the the readout. Said the only tweak she would consider is making the words "Solute Amount:" bold, but she was not sure. She definitely felt putting it in a panel would be too heavy handed.
@amyh-phet also said values are included in the teacher tips (we should probably match these):
The values I used from the Beaker sim match the teacher tips, but only to 1 decimal place. Do you want 3 decimal places?
@ariel-phet says that if this is what's in the teacher tips, then these are the values that we should have in the model. I will use these exact values, to 3 decimal places.
Other decisions: • leave font as is for now, consistent with everything else on the screen • keep this feature hidden behind query parameter
Values for molar mass have been changed as specified in https://github.com/phetsims/beers-law-lab/issues/148#issuecomment-178091606.
@amyh-phet please test that the displayed values look correct in this dev version (note showSoluteAmount
query parameter to enable this feature):
@pixelzoom Displayed values for solute amount are correct for the concentrations and volumes displayed on screen. Verified for drink mix and nickel (II) chloride. Can test other solutions if needed.
I verified that the sim builds with grunt --brand=phet-io
and runs with ?togetherEvents.log=console&phet-io-standalone
.
@samreid I'll need your assistance to verify that concentrationScreen.model.solution.soluteGramsProperty
looks correct in the data stream. Please contact me when you have time, or feel free to verify without me if you have time when I'm unavailable.
@samreid Never mind, I consulted with @jbphet on the data stream. soluteGramsProperty
is present (in the console) and looks correct.
All work completed for this issue.
Verified by @phet-steele in https://github.com/phetsims/tasks/issues/532#issuecomment-193459903. Closing.
Migrating this issue from https://github.com/phetsims/concentration/issues/47, where @kathy-phet said: