search

phetsims / beers-law-lab

"Beer's Law Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/beers-law-lab
GNU General Public License v3.0
2 stars 9 forks source link

Add Solute link to nameProperty #292

Closed pixelzoom closed 1 year ago

pixelzoom commented 2 years ago

In https://github.com/phetsims/ph-scale/issues/246, we decided to link nameProperty for Solutes to their associated translated StringProperty. I assume we'll want to do the same thing for Solutes in beers-law-lab.

@arouinfar does that sound correct?

Note that https://github.com/phetsims/axon/issues/414 is a prerequisite for this.

arouinfar commented 2 years ago

@arouinfar does that sound correct?

Yes, that's correct @pixelzoom

pixelzoom commented 2 years ago

Done in the above commits. @arouinfar ready for review, close if OK.

Solute now has a linked nameProperty:

screenshot_1888

It seemed like this enhancement should also be made for the solutions that appear in the Beer's Law screen, so I went ahead and did that too. These solutions also have a formulaProperty, which links to the corresponding solute formulaProperty.

screenshot_1890
arouinfar commented 1 year ago

It seemed like this enhancement should also be made for the solutions that appear in the Beer's Law screen, so I went ahead and did that too. These solutions also have a formulaProperty, which links to the corresponding solute formulaProperty.

Good call @pixelzoom, thanks!

@arouinfar ready for review, close if OK.

Everything looks good in master, closing.