`beakerUnits=milliliters` displays incorrect values

phetsims / beers-law-lab

"Beer's Law Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/beers-law-lab

GNU General Public License v3.0

2 stars 9 forks source link

`beakerUnits=milliliters` displays incorrect values #295

Closed arouinfar closed 1 year ago

arouinfar commented 1 year ago

Noticed when reviewing #293

Switching the beaker units to mL swaps out the units string, but doesn't correctly convert the values. The beaker labels should read 500 mL and 1000 mL. The behavior is correct in the latest published version, but broken in master (currently reads ½ mL and 1 mL).

pixelzoom commented 1 year ago

Good catch. This was actually broken in 90be4193 when I added support for dynamic locale. It's fixed in the above commit. The screenshots below show the beaker labels when switching the "Beaker units" preference.

@arouinfar feel free to take a peek. But I'm not going to assign this to you to review because it's so simple. Closing.