Closed pixelzoom closed 1 year ago
Done, example below, "cm". Distance/position units are not really important in the Concentration screen, but they are in the Beer's Law screen.
Note that origin (0,0) is at the top-left of the layoutBounds (red rectangle with ?dev
). Kind of weird that +y is down, but would be costly to change. Maybe document in PhET-iO Guide?
@arouinfar please review, close if OK.
Thanks @pixelzoom. The units look good.
Kind of weird that +y is down, but would be costly to change. Maybe document in PhET-iO Guide?
No need to change the coordinate system, but this seems like something that could go in phetioDocumentation
. Here's an example from Molecule Polarity:
The position of this atom. (0,0) is at the upper-LEFT, +x is to the right, and +y is DOWN.
This sim has a base class BLLMovable for all things that have a positionProperty
. Rather than hunt down every one of those and add (e.g.) "The position of the ruler. (0,0) is at the upper-LEFT, +x is to the right, and +y is DOWN.", I just added one generic description that will appear for all positionProperty -- see screenshot below.
Back to @arouinfar for review.
Thanks @pixelzoom! The generic positionProperty documentation looks good to me.
While working on https://github.com/phetsims/beers-law-lab/issues/306, I noticed that positionProperty is missing units in the model.