Closed pixelzoom closed 1 year ago
My preference would be to also make the dropper have a fixed position here. Otherwise we'll be circling back to this when the sim gets alt input support.
Yes, let's fix the position of the dropper @pixelzoom.
In case someone in the future questions this decision, the many reasons why the movable dropper was problematic in ph-scale are documented here: https://github.com/phetsims/ph-scale/issues/270#issuecomment-1398855808
Next questions is where should the fixed position of the dropper be? The default when you start the sim is the first screenshot below. I have a slight aesthetic preference for centering it between the faucet and right edge of the beaker, second screenshot below -- @arouinfar is that OK with you?
Centered looks good to me @pixelzoom.
Done in the above commit. @arouinfar please have a look in master, close if OK.
I'm glad we're doing this for the first version of the sims to have API files, so we don't need a migration rule.
Looks good, thanks!
Reopening to confirm in https://github.com/phetsims/qa/issues/894. It looks like changes I made during dev testing did not get into the 1.7 release branch.
@samreid @matthew-blackman FYI.
Still OK in 1.7 branch. Closing.
Related to https://github.com/phetsims/qa/issues/889.
This sim has all of the same problem with the movable dropper that we encountered in https://github.com/phetsims/ph-scale/issues/270. Should we make the dropper also have a fixed position in this sim? Or is this sim somehow different because the shaker is (necessarily) movable?
My preference would be to also make the dropper have a fixed position here. Otherwise we'll be circling back to this when the sim gets alt input support.