search

phetsims / beers-law-lab

"Beer's Law Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/beers-law-lab
GNU General Public License v3.0
2 stars 9 forks source link

"Concentration" meter body should not be movable. #324

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

The probe makes sense to be movable. But in the spirit of #323 and others, let's remove the positionProperty for the meter's body.

pixelzoom commented 1 year ago

Done in the above commit. The default body position looked reasonable, so that's the position I used.

@arouinfar please verify, close if OK.

arouinfar commented 1 year ago

Thanks @pixelzoom. Looks good!

pixelzoom commented 1 year ago

Reopening to confirm in https://github.com/phetsims/qa/issues/894. It looks like changes I made during dev testing did not get into the 1.7 release branch.

@samreid @matthew-blackman FYI.

pixelzoom commented 1 year ago

Looks OK in 1.7. Closing.