Uninstrument cuvetteNode.visibleProperty

[Nancy-Salpepi]

Test device MacBook Air (m1 chip)

Operating System 13.1

Browser chrome 110

Problem description

Discussed with @arouinfar on Slack

For https://github.com/phetsims/qa/issues/894, on the Beer's Law Screen it is possible to set the cuvetteNode.visibleProperty to false. There is no reason to hide the cuvette (and the data from the detector still reads as though the cuvette is present). Is it possible to uninstrument (or if not, to un-feature)?

This will also need to be deleted from the overrides file.

Visuals

[pixelzoom]

Yes, it's possible to uninstrument or unfeature beersLawLab.beersLawScreen.view.cuvetteNode.visibleProperty. If there's no reason to hide it, I recommend uninstrumenting. @arouinfar is that OK with you?

[pixelzoom]

While we're at it... Is there any reason to hide the AT Detector? Should we also uninstrument beersLawLab.beersLawScreen.view.detectorNode.visibleProperty?

[arouinfar]

If there's no reason to hide it, I recommend uninstrumenting. @arouinfar is that OK with you?

Yes, uninstrumenting would be my preference.

While we're at it... Is there any reason to hide the AT Detector?

Hiding the detector doesn't lead to broken-looking situations like the cuvette or light #310, so we can probably leave it alone. It could be useful to temporarily hide for prediction purposes, but there are other alternatives (like moving probe out of the path). I don't have a strong feeling either way, so I'll let you make that call @pixelzoom.

[pixelzoom]

OK, I guess we'll keep beersLawLab.beersLawScreen.view.detectorNode.visibleProperty for its hypothetical usefulness.

beersLawLab.beersLawScreen.view.cuvetteNode.visibleProperty was uninstrumented in the above commits to master. So it no longer exists. See screenshot below.

I still need to cherry-pick to 1.7. That involves beers-law-lab and phet-io-sim-specific.

[pixelzoom]

Cherry-picks completed, ready for verification in next RC.

[pixelzoom]

Verification in the next RC should include the following for beers-law-lab only:

• Run the sim in Studio. Search for cuvetteNode.visiblePropertyto verify that it no longer exists.

[stemilymill]

looks good