search

phetsims / beers-law-lab

"Beer's Law Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/beers-law-lab
GNU General Public License v3.0
2 stars 9 forks source link

Remove Solute button only removes particles that have reached the fluid/bottom of container. #68

Closed orejolaphet closed 10 years ago

orejolaphet commented 10 years ago

Remove Solute button only removes particles that have reached the fluid/bottom of container. Possibly as a result of the fix to issue #66.

May be low priority considering to completely remove all solute requires one to just wait until all the dispensed solute as reached the fluid. Only making a note because this behavior was not seen in previous versions.

To recreate use the shaker to dispense a large amount of solute. While there is some solid in the air and some on the bottom of the container select "Remove Solute". Only the solute on the bottom of the container/mixed with the fluid will be removed.

pixelzoom commented 10 years ago

As yes... The "Remove Solute" button appears to apply only to solute that is in solution or on the bottom of the beaker. We never decided what to do about solute that has left the shaker but has not reached the solution (or bottom of the beaker.) I'm guessing that particles in motion should be immediately removed.

@learnthinkteach, can you please confirm that particles in motion should be deleted when the "Remove Solute" button is pressed?

pixelzoom commented 10 years ago

This is easy to fix, requires patching 3 files. If you'd like it fixed for 1.2.0 release, another release candidate and test cycle (of Beer's and Concentration) will be required. So also let me know whether you want this fixed in 1.2.0. I recommend that we do it.

learnthinkteach commented 10 years ago

Confirmed: falling solute particles destined for the beaker should disappear when "remove solute" is selected. This is consisted with the java sim, and also makes the most sense. I reproduced this, and the present state is weird (and not pedagogically useful) when the falling particles "remain in play". Please fix.

pixelzoom commented 10 years ago

Fixed in master and 1.2 branches, will appear in 1.2.0-rc.3.

orejolaphet commented 10 years ago

No longer present in Beer's Law Lab 1.2.0-rc-3 & Concentration 1.1.0-rc.3. Closing.