phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Strange static object in IntensityMeter #275

Closed jessegreenberg closed 9 years ago

jessegreenberg commented 9 years ago

In IntensityMeter, there is the following static object:

    // @public static
    {
      Reading: Reading
    } );

Reading points to the Reading object loaded in modules. This seems like a strange pattern to me. The Reading object could be loaded into others with require instead of through the IntensityMeter static. If this is a necessary static, could some documentation added to describe why?

jessegreenberg commented 9 years ago

Search through code reveals zero cases of IntensityMeter.Reading. Can this public static be deleted?

samreid commented 9 years ago

Thanks @jessegreenberg, that does indeed appear unused. I removed it above.

jessegreenberg commented 9 years ago

Thanks @samreid, looks good. Closing.