search

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Should public variables in Substance.js be @public (read-only)? #278

Closed jessegreenberg closed 8 years ago

jessegreenberg commented 8 years ago

In Substance, the documentation at the top of the file states claims that the state for the medium is immutable. This suggests that the properties of Substance should not be changed with the API.

Should the properties of Substance be identified with @public (read-only) instead of @public?

samreid commented 8 years ago

Fixed above, @jessegreenberg feel free to review if you wish.

jessegreenberg commented 8 years ago

Looks great @samreid. Closing.