Closed ariel-phet closed 8 years ago
It looks like part of the intensity meter layout is using the width of the intensity meter body, and the width is being augmented by the numeric readout. Since the strings should appear like so:
or
This will not be a problem unless translators substitute a much longer symbol for %
or -
. I tried adding the Belarusian translation for "percent" and it looked like this:
Since we do permit translation of this symbol, perhaps I should add a max width to this text.
Putting maxWidth to be 85% of the width of the white panel, it looks like this:
With the English case still looking good:
This is a non-invasive change and will not require significant re-testing (just a spot test on 1 platform), so I'll go ahead and commit it to master and the 1.0 branch.
I've made this commit in the 1.0 branch and merged to master. I'll mark this for "Needs Spot Test" in the next RC.
EDIT: I'll use the pre-existing "ready-for-review" label.
Looks good! Closing.
stringTest=long shows some odd behavior for the intensity meter (the wire disconnects from the meter body).
May not need to fix, but it does appear to happen with anything that goes above the stringTest=double.
@samreid should investigate to see if this is an easy fix