search

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Create a new screenshot #337

Closed samreid closed 8 years ago

samreid commented 8 years ago

Some visual elements have changed size since the last screenshot. I considered just "sticking with it" since it would be OK as a thumbnail, but for consistency I decided to create a new screenshot since we may use it for other purposes in the future. For #336

samreid commented 8 years ago

With the smaller intensity probe, the rest of the configuration looks odd (light spilling out of the probe), so I'm going to move a few other things around as well.

samreid commented 8 years ago

Here's a sneak peek of the new screenshot. @arouinfar please let me know if you recommend any changes:

image

samreid commented 8 years ago

Committed above, reassigning to @arouinfar for review.

samreid commented 8 years ago

This new screenshot does not do too good of a job showing the transparency of the transmitted and reflected beams. Perhaps we can do better?

samreid commented 8 years ago

I've improved the screenshot in the above commit, here's a visual difference:

https://github.com/phetsims/bending-light/commit/e3ef9d43185c872f36d97b5a56b4ba534885e81f

This seems like it solves the problems in the previous version, and I just had the light extend across the probe, and it doesn't look too odd. It would still be good for @arouinfar to double check it though.

samreid commented 8 years ago

Moving forward with publishing in #336...

arouinfar commented 8 years ago

Looks good @samreid. Closing.