search

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Migrate Java strings #341

Closed samreid closed 8 years ago

samreid commented 8 years ago

From https://github.com/phetsims/bending-light/issues/50 we should migrate the Java strings to Babel.

ariel-phet commented 8 years ago

@samreid note that a number of translations have occurred already. I would highly suggest that when you do this migration, only now move over strings for locales which have NOT yet been translated (we would not want to wipe out or change any work done in the current translations)

samreid commented 8 years ago

Sounds great @ariel-phet, will do.

samreid commented 8 years ago

I know some key names have changed during the port, so I compared them to see if it is worth any effort here. Here are the shared keys:

["intro", "air", "water", "glass", "custom", "prisms", "mysteryA", "mysteryB", "material", "miss", "indexOfRefraction", "objects", "environment", "intensity", "ray", "wave", "diamond", "time", "moreTools"]

This is 19/33 keys that will be portable.

samreid commented 8 years ago

Also, based on previous discussions it seemed like it would be nice but not essential to filter out the unused keys. I do not have time at the moment to write a robust reusable filter so I am planning to proceed with just moving all of the strings including the unused ones.

samreid commented 8 years ago

Pushed to babel above. I'll create a chipper or issue about filtering the unused strings.