phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Automated Testing Sim Error (7/5/2016 9:58 AM) #347

Closed phet-steele closed 8 years ago

phet-steele commented 8 years ago
Error: Module name "BENDING_LIGHT/bendingLight" has not been loaded yet for context: _. Use require([])
http://requirejs.org/docs/errors.html#notloaded
    at makeError (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:166:13)
    at Object.localRequire [as require] (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:1392:30)
    at requirejs (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:1737:20)
    at http://phettest.colorado.edu/bending-light/js/common/view/FloatingLayout.js?bust=1467734868024:13:22
    at Object.execCb (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:1650:25)
    at Object.check (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:866:35)
    at Object.enable (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:1143:14)
    at Object.init (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:774:16)
    at callGetModule (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:1170:55)
    at Object.completeLoad (http://phettest.colorado.edu/sherpa/lib/require-2.1.11.js:1544:11)
samreid commented 8 years ago

Tests OK in my canary:

image

samreid commented 8 years ago

Runs OK in my mac chrome and mac firefox too. Can you provide more details as to how/where it failed?

samreid commented 8 years ago

I tried running from phettest "Automated Tests" and saw this:

image

@phet-steele can you reproduce the problem reliably?

phet-steele commented 8 years ago

@samreid I did not get it a second time.

samreid commented 8 years ago

Perhaps a spurious requirejs loading issue, I'll close and we can reopen if it recurs.

phet-steele commented 8 years ago

@samreid this has reoccurred on the 7/12 automated testing.

samreid commented 8 years ago

Perhaps I can investigate this as we work toward #351, unassigning until then.

samreid commented 8 years ago

Perhaps on a slower computer or throttled connection we could trigger the not yet loaded problem?

samreid commented 8 years ago

I throttled at 3G and despite taking about 30 seconds to launch, there were no errors like above. I wonder if I eliminate FloatingLayout.js as in the stack above, if the problem would disappear. This is happening in #348

samreid commented 8 years ago

Found the likely culprit and amended it above. This seems likely enough to be the issue that I'm inclined to close the issue, but @phet-steele please re-open if it recurs in a subsequent weekly test.