search

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

sim relies on align:'right' default for Panels #354

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new MediumControlPanel (http://localhost/~cmalley/GitHub/bending-light/js/common/view/MediumControlPanel.js?bust=1472164707522:296:23)
    at new IntroView (http://localhost/~cmalley/GitHub/bending-light/js/intro/view/IntroView.js?bust=1472164707522:125:33)
    at IntroScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/intro/IntroScreen.js?bust=1472164707522:35:16)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
    at http://localhost/~cmalley/GitHub/bending-light/js/bending-light-main.js?bust=1472164707522:38:15
VM12584 Panel.js?bust=1472164707522:53

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new MediumControlPanel (http://localhost/~cmalley/GitHub/bending-light/js/common/view/MediumControlPanel.js?bust=1472164707522:296:23)
    at new IntroView (http://localhost/~cmalley/GitHub/bending-light/js/intro/view/IntroView.js?bust=1472164707522:141:36)
    at IntroScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/intro/IntroScreen.js?bust=1472164707522:35:16)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
    at http://localhost/~cmalley/GitHub/bending-light/js/bending-light-main.js?bust=1472164707522:38:15
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new IntroView (http://localhost/~cmalley/GitHub/bending-light/js/intro/view/IntroView.js?bust=1472164707522:205:29)
    at IntroScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/intro/IntroScreen.js?bust=1472164707522:35:16)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
    at http://localhost/~cmalley/GitHub/bending-light/js/bending-light-main.js?bust=1472164707522:38:15
    at window.phetLaunchSimulation (http://localhost/~cmalley/GitHub/joist/js/SimLauncher.js?bust=1472164707522:54:11)
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new IntroView (http://localhost/~cmalley/GitHub/bending-light/js/intro/view/IntroView.js?bust=1472164707522:363:20)
    at IntroScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/intro/IntroScreen.js?bust=1472164707522:35:16)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
    at http://localhost/~cmalley/GitHub/bending-light/js/bending-light-main.js?bust=1472164707522:38:15
    at window.phetLaunchSimulation (http://localhost/~cmalley/GitHub/joist/js/SimLauncher.js?bust=1472164707522:54:11)
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new MediumControlPanel (http://localhost/~cmalley/GitHub/bending-light/js/common/view/MediumControlPanel.js?bust=1472164707522:296:23)
    at new PrismsView (http://localhost/~cmalley/GitHub/bending-light/js/prisms/view/PrismsView.js?bust=1472164707522:104:41)
    at PrismsScreen.Screen.call.navigationBarIcon [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/prisms/PrismsScreen.js?bust=1472164707522:37:16)
    at PrismsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at PrismsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
    at http://localhost/~cmalley/GitHub/bending-light/js/bending-light-main.js?bust=1472164707522:38:15
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new PrismsView (http://localhost/~cmalley/GitHub/bending-light/js/prisms/view/PrismsView.js?bust=1472164707522:127:29)
    at PrismsScreen.Screen.call.navigationBarIcon [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/prisms/PrismsScreen.js?bust=1472164707522:37:16)
    at PrismsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at PrismsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
    at http://localhost/~cmalley/GitHub/bending-light/js/bending-light-main.js?bust=1472164707522:38:15
    at window.phetLaunchSimulation (http://localhost/~cmalley/GitHub/joist/js/SimLauncher.js?bust=1472164707522:54:11)
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new MediumControlPanel (http://localhost/~cmalley/GitHub/bending-light/js/common/view/MediumControlPanel.js?bust=1472164707522:296:23)
    at new PrismToolboxNode (http://localhost/~cmalley/GitHub/bending-light/js/prisms/view/PrismToolboxNode.js?bust=1472164707522:156:36)
    at new PrismsView (http://localhost/~cmalley/GitHub/bending-light/js/prisms/view/PrismsView.js?bust=1472164707522:163:28)
    at PrismsScreen.Screen.call.navigationBarIcon [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/prisms/PrismsScreen.js?bust=1472164707522:37:16)
    at PrismsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at PrismsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new MediumControlPanel (http://localhost/~cmalley/GitHub/bending-light/js/common/view/MediumControlPanel.js?bust=1472164707522:296:23)
    at MoreToolsView.IntroView [as constructor] (http://localhost/~cmalley/GitHub/bending-light/js/intro/view/IntroView.js?bust=1472164707522:125:33)
    at new MoreToolsView (http://localhost/~cmalley/GitHub/bending-light/js/more-tools/view/MoreToolsView.js?bust=1472164707522:40:15)
    at MoreToolsScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/more-tools/MoreToolsScreen.js?bust=1472164707522:37:16)
    at MoreToolsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at MoreToolsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at new MediumControlPanel (http://localhost/~cmalley/GitHub/bending-light/js/common/view/MediumControlPanel.js?bust=1472164707522:296:23)
    at MoreToolsView.IntroView [as constructor] (http://localhost/~cmalley/GitHub/bending-light/js/intro/view/IntroView.js?bust=1472164707522:141:36)
    at new MoreToolsView (http://localhost/~cmalley/GitHub/bending-light/js/more-tools/view/MoreToolsView.js?bust=1472164707522:40:15)
    at MoreToolsScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/more-tools/MoreToolsScreen.js?bust=1472164707522:37:16)
    at MoreToolsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at MoreToolsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at MoreToolsView.IntroView [as constructor] (http://localhost/~cmalley/GitHub/bending-light/js/intro/view/IntroView.js?bust=1472164707522:205:29)
    at new MoreToolsView (http://localhost/~cmalley/GitHub/bending-light/js/more-tools/view/MoreToolsView.js?bust=1472164707522:40:15)
    at MoreToolsScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/more-tools/MoreToolsScreen.js?bust=1472164707522:37:16)
    at MoreToolsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at MoreToolsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
    at http://localhost/~cmalley/GitHub/bending-light/js/bending-light-main.js?bust=1472164707522:38:15
VM12584 Panel.js?bust=1472164707522:53 

>>>> sim relies on align:right
VM12584 Panel.js?bust=1472164707522:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164707522:50:15)
    at MoreToolsView.IntroView [as constructor] (http://localhost/~cmalley/GitHub/bending-light/js/intro/view/IntroView.js?bust=1472164707522:363:20)
    at new MoreToolsView (http://localhost/~cmalley/GitHub/bending-light/js/more-tools/view/MoreToolsView.js?bust=1472164707522:40:15)
    at MoreToolsScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/bending-light/js/more-tools/MoreToolsScreen.js?bust=1472164707522:37:16)
    at MoreToolsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:134:25)
    at MoreToolsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164707522:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164707522:439:13)
pixelzoom commented 8 years ago

None of the above call sites use the minWidth option, so their behavior will be unaffected. Closing.