phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

[iPhone] Reflected wave animation at wrong angle #368

Closed samreid closed 7 years ago

samreid commented 7 years ago

image

samreid commented 7 years ago

This looks like it was also buggy on 1.1.1 http://phet.colorado.edu/sims/html/bending-light/1.1.1/bending-light_en.html but the wave was too gray to notice it.

Flagging for high priority since this is very buggy on our main site now. Should we revert until this is fixed? Try to quickly fix the animation angle? @ariel-phet what do you recommend?

mattpen commented 7 years ago

@samreid - I can recreate this bug on iPad 2 Mini, iOS 10.2.1 on both versions 1.1.2 and 1.1.1

(Apologies for the poor screenshot-fu)

win_20170202_11_38_18_pro

ariel-phet commented 7 years ago

@samreid revert

phet-steele commented 7 years ago

@samreid talking about #359?

samreid commented 7 years ago

Yes, @phet-steele that seems correct.

@jonathanolson can you please publish a maintenance revert?

phet-steele commented 7 years ago

@samreid @ariel-phet why would a revert be necessary here? It is still a problem in 1.1.1, 1.1.2 didn't introduce a new bug, and clearly from the screenshots in #359, the wave was NOT always too gray to notice.

jonathanolson commented 7 years ago

Revert complete, bumped to 1.1.3 (same behavior as 1.1.1).

ariel-phet commented 7 years ago

@phet-steele 1.1.2 made the bug more obvious

jonathanolson commented 7 years ago

Unassigned, please reassign if you want me to fix or assist with a fix for the underlying problem.

kathy-phet commented 7 years ago

Note, this bug does not appear in webgl=false version, only webgl version.

kathy-phet commented 7 years ago

@jonathanolson - When there is a lull due to testing or other things you are waiting on, can you take a look at this error since it is only in WebGL code?

kathy-phet commented 7 years ago

It actually seems like it might be something general in WebGL node that should be corrected, and just manifests itself here for some reason.

ariel-phet commented 7 years ago

Marking at low priority since this is a "as time allows" bug and has not been reported to phethelp

phet-steele commented 7 years ago

Closing as a duplicate of #359, relevant info has been moved.