search

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Use SCENERY_PHET/WireNode #377

Closed samreid closed 5 years ago

samreid commented 6 years ago

WireNode was generalized for Wave Interference, Bending Light should use it too.

samreid commented 6 years ago

Fixed, but will need testing and review before publication.

samreid commented 5 years ago

Perhaps we should wait for https://github.com/phetsims/scenery-phet/issues/395 review to complete.

samreid commented 5 years ago

@pixelzoom volunteered to take a look, thanks!

pixelzoom commented 5 years ago

Review completed. I don't see any problem with the above commit, or when running the sim.

Back to @samreid in case there's more to be done here. Feel free to close.

samreid commented 5 years ago

Thanks, closing.