KatieWoe
commented
3 years ago Closed KatieWoe closed 3 years ago
KatieWoe
commented
3 years ago 
samreid
commented
3 years ago This looks similar to https://github.com/phetsims/joist/issues/656
KatieWoe
commented
3 years ago Looks like it might have gone away, but then came back:
bending-light : fuzz : unbuilt : assertSlow
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/bending-light/bending-light_en.html?continuousTest=%7B%22test%22%3A%5B%22bending-light%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22assertSlow%22%5D%2C%22snapshotName%22%3A%22snapshot-1607071519170%22%2C%22timestamp%22%3A1607081062104%7D&brand=phet&eall&fuzz&memoryLimit=1000
Query: brand=phet&eall&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/assert/js/assert.js:25:13)
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/scenery/js/nodes/Node.js:1369:23
at ShadedRectangle.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/scenery/js/nodes/Node.js:1374:10)
at Node.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/scenery/js/nodes/Node.js:1218:29)
at TinyStaticProperty.get (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/axon/js/TinyStaticProperty.js:38:10)
at TinyStaticProperty.get value [as value] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/axon/js/TinyProperty.js:52:17)
at Node.getBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/scenery/js/nodes/Node.js:1784:32)
at Node.getRightBottom (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/scenery/js/nodes/Node.js:3131:17)
at Node.get rightBottom [as rightBottom] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/scenery/js/nodes/Node.js:3133:35)
at new NodeProperty (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607071519170/scenery/js/util/NodeProperty.js:25:16)
id: Bayes Chrome
Snapshot from 12/4/2020, 1:45:19 AMbending-light : fuzz : unbuilt : assertSlow
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/bending-light/bending-light_en.html?continuousTest=%7B%22test%22%3A%5B%22bending-light%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22assertSlow%22%5D%2C%22snapshotName%22%3A%22snapshot-1607422608277%22%2C%22timestamp%22%3A1607435102996%7D&brand=phet&eall&fuzz&memoryLimit=1000
Query: brand=phet&eall&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/assert/js/assert.js:25:13)
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/scenery/js/nodes/Node.js:1369:23
at ShadedRectangle.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/scenery/js/nodes/Node.js:1374:10)
at Node.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/scenery/js/nodes/Node.js:1218:29)
at TinyStaticProperty.get (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/axon/js/TinyStaticProperty.js:38:10)
at TinyStaticProperty.get value [as value] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/axon/js/TinyProperty.js:52:17)
at Node.getBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/scenery/js/nodes/Node.js:1784:32)
at Node.getRightBottom (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/scenery/js/nodes/Node.js:3131:17)
at Node.get rightBottom [as rightBottom] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/scenery/js/nodes/Node.js:3133:35)
at new NodeProperty (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607422608277/scenery/js/util/NodeProperty.js:25:16)
id: Bayes Chrome
Snapshot from 12/8/2020, 3:16:48 AMShowing up again more consistently.
bending-light : fuzz : unbuilt : assertSlow
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/bending-light/bending-light_en.html?continuousTest=%7B%22test%22%3A%5B%22bending-light%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22assertSlow%22%5D%2C%22snapshotName%22%3A%22snapshot-1607895437240%22%2C%22timestamp%22%3A1607908910290%7D&brand=phet&eall&fuzz&memoryLimit=1000
Query: brand=phet&eall&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/assert/js/assert.js:25:13)
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1369:23
at ShadedRectangle.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1374:10)
at Node.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1218:29)
at TinyStaticProperty.get (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/axon/js/TinyStaticProperty.js:38:10)
at TinyStaticProperty.get value [as value] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/axon/js/TinyProperty.js:52:17)
at Node.getBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1784:32)
at Node.getRightBottom (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:3131:17)
at Node.get rightBottom [as rightBottom] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:3133:35)
at new NodeProperty (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/util/NodeProperty.js:25:16)
id: Bayes Chrome
Snapshot from 12/13/2020, 2:37:17 PM
----------------------------------
bending-light : fuzz : unbuilt : assertSlow
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/bending-light/bending-light_en.html?continuousTest=%7B%22test%22%3A%5B%22bending-light%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22assertSlow%22%5D%2C%22snapshotName%22%3A%22snapshot-1607895437240%22%2C%22timestamp%22%3A1607923926218%7D&brand=phet&eall&fuzz&memoryLimit=1000
Query: brand=phet&eall&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/assert/js/assert.js:25:13)
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1369:23
at ShadedRectangle.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1374:10)
at Node.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1218:29)
at TinyStaticProperty.get (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/axon/js/TinyStaticProperty.js:38:10)
at TinyStaticProperty.get value [as value] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/axon/js/TinyProperty.js:52:17)
at Node.getBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1784:32)
at Node.getRightBottom (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:3131:17)
at Node.get rightBottom [as rightBottom] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:3133:35)
at new NodeProperty (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/util/NodeProperty.js:25:16)
id: Bayes Chrome
Snapshot from 12/13/2020, 2:37:17 PM
----------------------------------
bending-light : fuzz : unbuilt : assertSlow
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/bending-light/bending-light_en.html?continuousTest=%7B%22test%22%3A%5B%22bending-light%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22assertSlow%22%5D%2C%22snapshotName%22%3A%22snapshot-1607895437240%22%2C%22timestamp%22%3A1607939499745%7D&brand=phet&eall&fuzz&memoryLimit=1000
Query: brand=phet&eall&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/assert/js/assert.js:25:13)
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1369:23
at ShadedRectangle.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1374:10)
at Node.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1218:29)
at TinyStaticProperty.get (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/axon/js/TinyStaticProperty.js:38:10)
at TinyStaticProperty.get value [as value] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/axon/js/TinyProperty.js:52:17)
at Node.getBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1784:32)
at Node.getRightBottom (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:3131:17)
at Node.get rightBottom [as rightBottom] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:3133:35)
at new NodeProperty (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/util/NodeProperty.js:25:16)
id: Bayes Chrome
Snapshot from 12/13/2020, 2:37:17 PM
----------------------------------
bending-light : fuzz : unbuilt : assertSlow
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/bending-light/bending-light_en.html?continuousTest=%7B%22test%22%3A%5B%22bending-light%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22assertSlow%22%5D%2C%22snapshotName%22%3A%22snapshot-1607895437240%22%2C%22timestamp%22%3A1607955442494%7D&brand=phet&eall&fuzz&memoryLimit=1000
Query: brand=phet&eall&fuzz&memoryLimit=1000
Uncaught Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
Error: Assertion failed: Bounds mismatch after validateBounds: [x:(8.849999999999994,126.15),y:(11,69)], expected: [x:(5.849999999999994,129.15),y:(8,72)]
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/assert/js/assert.js:25:13)
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1369:23
at ShadedRectangle.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1374:10)
at Node.validateBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1218:29)
at TinyStaticProperty.get (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/axon/js/TinyStaticProperty.js:38:10)
at TinyStaticProperty.get value [as value] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/axon/js/TinyProperty.js:52:17)
at Node.getBounds (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:1784:32)
at Node.getRightBottom (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:3131:17)
at Node.get rightBottom [as rightBottom] (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/nodes/Node.js:3133:35)
at new NodeProperty (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1607895437240/scenery/js/util/NodeProperty.js:25:16)
id: Bayes Chrome
Snapshot from 12/13/2020, 2:37:17 PMThis issue is puzzling. If I omit the titleNode and the chartNode from the bodyNode, then the problem is not triggered:
Index: js/more-tools/view/WaveSensorNode.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/more-tools/view/WaveSensorNode.js b/js/more-tools/view/WaveSensorNode.js
--- a/js/more-tools/view/WaveSensorNode.js (revision d2b7db91dba026073989a43c2d3f5a99f13a66a9)
+++ b/js/more-tools/view/WaveSensorNode.js (date 1609177938217)
@@ -131,7 +131,7 @@
if ( titleNode.width > rectangleWidth - 15 ) {
titleNode.scale( ( rectangleWidth - 15 ) / titleNode.width );
}
- this.bodyNode.addChild( titleNode );
+ // this.bodyNode.addChild( titleNode );
titleNode.centerX = outerRectangle.centerX;
const fractionalVerticalDistanceToTitle = 0.82;
titleNode.y = this.bodyNode.height * fractionalVerticalDistanceToTitle;
@@ -141,7 +141,7 @@
new Series( waveSensor.probe1.seriesProperty, darkProbeColor ),
new Series( waveSensor.probe2.seriesProperty, lightProbeColor )
] );
- this.bodyNode.addChild( this.chartNode );
+ // this.bodyNode.addChild( this.chartNode );
// Create the probes
this.probe1Node = new ProbeNodeWrapper( waveSensor.probe1, '#5c5d5f', modelViewTransform ); // @public (read-only)However, both the title and chartNode appear to have legal, numeric bounds. @jonathanolson can you please advise?
jonathanolson
commented
3 years ago @samreid I recall this happening in ?eall when client code directly mutated the relevant bounds. I'll do a brief check.
jonathanolson
commented
3 years ago innerMostRectangle.bounds.erode( 3 )
Presumably changing this to eroded should work, I'll test.
jonathanolson
commented
3 years ago Verified it seems to fix the above issue. @samreid can you verify? Should we update the assertion message to better hint for that, now that we're running ?eall more?
samreid
commented
3 years ago That fix looks great, thanks! A better assertion message would be helpful, would you like a side issue for that?
jonathanolson
commented
3 years ago Handled above, does that look good? (Don't feel like a side issue is needed, unless additional changes should be made).
samreid
commented
3 years ago Excellent, thanks! Closing.