search

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Rename Circle #399

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

Would it be possible to rename bending-light's Circle class? Maybe BendingLightCircle? It obvious conflicts with scenery, and I believe the PhET convention is to try to avoid this kind of name collision. I can't tell you how many times WebStorm has auto-added a bad import to bending-light.

samreid commented 3 years ago

I renamed it in the commit, @pixelzoom would you like to review?

pixelzoom commented 3 years ago

Thanks! Closing.