search

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Code Review: TypeScript port #404

Closed samreid closed 2 years ago

samreid commented 2 years ago

After porting to TypeScript in https://github.com/phetsims/bending-light/issues/401, I realized it would be great if someone else can code review it. I'm reluctant to ask now since at the last developer meeting, all other developers were still getting up to speed on TypeScript. But I'll mark this as a placeholder and request a review when appropriate.

samreid commented 2 years ago

I don't feel like this review is relatively high enough priority at the moment. Maybe this should be reconsidered as we evaluate TypeScript in December.

samreid commented 2 years ago

Maybe the best way to proceed is to incorporate TypeScript reviews into our standard reviews, closing.