search

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/bending-light
GNU General Public License v3.0
8 stars 8 forks source link

Suspicions devDependencies in package.json #409

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

Why does bending-light have these devDependencies in package.json? I don't see anything like this in package.json for other sims.

    "@typescript-eslint/eslint-plugin": "^5.0.0",
    "@typescript-eslint/parser": "^5.0.0",
    "eslint": "^8.0.1",
...
    "typescript": "^4.4.4"
samreid commented 2 years ago

Thanks, I think @zepumph found an extra installation of node_modules/typescript in bending-light this week.

samreid commented 2 years ago

Fixed, closing.

samreid commented 2 years ago

I also wrote to slack:

There were erroneous entries for dev dependencies in bending light, please pull and npm prune in that directory. Details in https://github.com/phetsims/bending-light/issues/409