Consider converting to default layoutBounds before PhET-iO publication

phetsims / bending-light

"Bending Light" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/bending-light

GNU General Public License v3.0

8 stars 8 forks source link

Consider converting to default layoutBounds before PhET-iO publication #415

Closed pixelzoom closed 7 months ago

pixelzoom commented 1 year ago

This sim currently uses non-default layoutBounds. In BendingLightConstants.ts:

    layoutBounds: new Bounds2( 0, 0, 834, 504 )

Per https://github.com/phetsims/phet-io/issues/1939... layoutBounds should not be changed for published PhET-iO sims because doing so may disrupt client customizations. So evaluate whether to change layoutBounds before publishing a PhET-iO version.

If you decide not to change layoutBounds, document why in BendingLightConstants.ts, and refer to this issue.

marlitas commented 7 months ago

Closing per dev meeting request 12/7/23.